Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Re-raise exceptions in rayrunner #1522

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[BUG] Re-raise exceptions in rayrunner #1522

merged 1 commit into from
Oct 25, 2023

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Oct 24, 2023

Previously prior to this change, if an error occurs during execution in the RayRunner:

  1. The "run_plan" thread will error out and die before sending any information on the return queue
  2. The Scheduler actor will block forever on the next result on the return queue via a .get()

This change re-raises those errors so that it surfaces in the scheduler, and prevents that issue from occurring.

@github-actions github-actions bot added the bug Something isn't working label Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1522 (00ed979) into main (ea7167b) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1522      +/-   ##
==========================================
- Coverage   74.76%   74.73%   -0.03%     
==========================================
  Files          60       60              
  Lines        6130     6140      +10     
==========================================
+ Hits         4583     4589       +6     
- Misses       1547     1551       +4     
Files Coverage Δ
daft/runners/ray_runner.py 90.55% <33.33%> (-0.94%) ⬇️

... and 1 file with indirect coverage changes

@jaychia jaychia merged commit ccd5878 into main Oct 25, 2023
25 of 26 checks passed
@jaychia jaychia deleted the jay/rayrunner-reraise branch October 25, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant