Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix credentials issues in colab/CI #1539

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Oct 27, 2023

  • We currently throw a ProviderError in colab/CI when attempting to query for S3 credentials
  • To circumvent this, we need to specify anonymous=True in all s3 accesses

@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation labels Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1539 (bc17bff) into main (ba1eb50) will increase coverage by 10.37%.
Report is 3 commits behind head on main.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1539       +/-   ##
===========================================
+ Coverage   74.85%   85.22%   +10.37%     
===========================================
  Files          61       54        -7     
  Lines        6296     5131     -1165     
===========================================
- Hits         4713     4373      -340     
+ Misses       1583      758      -825     
Files Coverage Δ
daft/io/_csv.py 94.73% <100.00%> (ø)
daft/io/_json.py 100.00% <100.00%> (ø)
daft/io/_parquet.py 100.00% <100.00%> (ø)
daft/io/common.py 88.88% <75.00%> (-3.12%) ⬇️

... and 17 files with indirect coverage changes

@jaychia jaychia merged commit 6bd8f51 into main Oct 27, 2023
37 checks passed
@jaychia jaychia deleted the jay/fix-notebooks-credentials branch October 27, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant