Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] [New Query Planner] [2/N] Push partition spec into physical plan, remove Coalesce logical op. #1540

Merged
merged 10 commits into from
Oct 30, 2023

Apply suggestions from code review

4b79560
Select commit
Loading
Failed to load commit list.
Merged

[FEAT] [New Query Planner] [2/N] Push partition spec into physical plan, remove Coalesce logical op. #1540

Apply suggestions from code review
4b79560
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 30, 2023 in 0s

85.21% (+0.00%) compared to 6bd8f51

View this Pull Request on Codecov

85.21% (+0.00%) compared to 6bd8f51

Details

Codecov Report

Merging #1540 (4b79560) into main (6bd8f51) will increase coverage by 0.00%.
Report is 4 commits behind head on main.
The diff coverage is 94.44%.

❗ Current head 4b79560 differs from pull request most recent head 824d5b5. Consider uploading reports for the commit 824d5b5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1540   +/-   ##
=======================================
  Coverage   85.20%   85.21%           
=======================================
  Files          54       54           
  Lines        5131     5120   -11     
=======================================
- Hits         4372     4363    -9     
+ Misses        759      757    -2     
Files Coverage Δ
daft/io/file_path.py 100.00% <100.00%> (ø)
daft/logical/builder.py 88.88% <100.00%> (-0.19%) ⬇️
daft/plan_scheduler/physical_plan_scheduler.py 100.00% <100.00%> (ø)
daft/runners/partitioning.py 81.03% <100.00%> (+0.33%) ⬆️
daft/dataframe/dataframe.py 89.58% <90.00%> (+0.12%) ⬆️