[FEAT] Enable Progress Bars for PyRunner and RayRunner #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
samster25
commented
Nov 15, 2023
•
samster25
commented
- Enables progress bars when in interactive mode (Notebook or IPython)
- Implementation for Pyrunner, RayRunner[Local] and RayRunner[Remote]
samster25
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1609 +/- ##
==========================================
+ Coverage 84.59% 87.29% +2.69%
==========================================
Files 54 52 -2
Lines 5201 5115 -86
==========================================
+ Hits 4400 4465 +65
+ Misses 801 650 -151
|
samster25
force-pushed
the
sammy/progress-bar-prototype-pyrunner
branch
from
af7ff8c
to
b52f6ec
Compare
samster25
changed the title
samster25
changed the title
jaychia
approved these changes
Nov 15, 2023
jaychia
approved these changes
Nov 17, 2023
| self.use_ray_tqdm = use_ray_tqdm | ||
| self.show_tasks_bar = show_tasks_bar | ||
| self.tqdm_mod = tqdm | ||
| self.pbars: dict[int, tqdm] = dict() |
There was a problem hiding this comment.
Initialize as self.pbars = {-1: ...}? We could also document here that -1 represents the progress for "All tasks".
There was a problem hiding this comment.
we actually dont want to initialize the the progress bar until we get a task. Otherwise the total is 0 and it's in a weird state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.