[BUG] Filter out size-0 directory marker files during s3 globs #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaychia
commented
Nov 17, 2023
src/daft-io/src/s3_like.rs
Outdated
| // However they can lead to unexpected globbing behavior since most users do not expect them to exist | ||
| |result_stream| { | ||
| result_stream | ||
| .filter_map(|fm| async move { |
There was a problem hiding this comment.
I cannot for the life of me get .filter(...) to work! 😭
.filter receives fm as a reference, which seems to cause a whole bunch of lifetime issues
There was a problem hiding this comment.
Moved logic to shared fn glob utility, inside of the stream! so we don't have to use the StreamExt::filter function anymore
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1629 +/- ##
==========================================
- Coverage 87.32% 84.86% -2.46%
==========================================
Files 51 55 +4
Lines 5040 5274 +234
==========================================
+ Hits 4401 4476 +75
- Misses 639 798 +159 |
samster25
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix CI failures: https://github.com/Eventual-Inc/daft-benchmarking/actions/runs/6899343721/job/18770787773