Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 1606 - Adding hour expression in date util #1637

Merged
merged 2 commits into from
Nov 21, 2023

Fixing bad return

418dc1e
Select commit
Loading
Failed to load commit list.
Merged

[FEAT] 1606 - Adding hour expression in date util #1637

Fixing bad return
418dc1e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 21, 2023 in 0s

85.02% (+0.13%) compared to c2d4c23

View this Pull Request on Codecov

85.02% (+0.13%) compared to c2d4c23

Details

Codecov Report

Merging #1637 (418dc1e) into main (c2d4c23) will increase coverage by 0.13%.
Report is 10 commits behind head on main.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1637      +/-   ##
==========================================
+ Coverage   84.88%   85.02%   +0.13%     
==========================================
  Files          55       55              
  Lines        5287     5314      +27     
==========================================
+ Hits         4488     4518      +30     
+ Misses        799      796       -3     
Files Coverage Δ
daft/series.py 92.38% <100.00%> (+0.04%) ⬆️
daft/expressions/expressions.py 90.85% <50.00%> (-0.24%) ⬇️

... and 7 files with indirect coverage changes