Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Greatly speed up Variable Length Concat #1748

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Dec 19, 2023

  • before Were we using Arrow Growable for Concating UTF8 and Binary Arrays, which only allocated memory for the offset array
  • Now we preallocate the value array since we know the complete size of the target array.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4e8528) 85.19% compared to head (d608fdb) 85.19%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1748   +/-   ##
=======================================
  Coverage   85.19%   85.19%           
=======================================
  Files          55       55           
  Lines        5518     5518           
=======================================
  Hits         4701     4701           
  Misses        817      817           

@samster25 samster25 changed the title Sammy/faster string concat [PERF] Greatly speed up Variable Length Concat Dec 20, 2023
@samster25 samster25 merged commit a07b301 into main Dec 20, 2023
43 of 44 checks passed
@samster25 samster25 deleted the sammy/faster-string-concat branch December 20, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant