Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add documentation for read_iceberg #1769

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Jan 9, 2024

  1. Add docstring
  2. Add API docs
  3. Adds a new section in user_guide/integrations for data_catalogs

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 9, 2024
@jaychia jaychia enabled auto-merge (squash) January 9, 2024 09:12
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd662c1) 84.76% compared to head (c995b1a) 84.69%.

❗ Current head c995b1a differs from pull request most recent head 3130602. Consider uploading reports for the commit 3130602 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1769      +/-   ##
==========================================
- Coverage   84.76%   84.69%   -0.08%     
==========================================
  Files          55       55              
  Lines        5554     5554              
==========================================
- Hits         4708     4704       -4     
- Misses        846      850       +4     
Files Coverage Δ
daft/io/_iceberg.py 21.27% <ø> (ø)

... and 2 files with indirect coverage changes

@jaychia jaychia merged commit a994c7b into main Jan 9, 2024
38 checks passed
@jaychia jaychia deleted the jay/add-iceberg-docs branch January 9, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant