[FEAT] Not_Null Expression #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1777 +/- ##
==========================================
- Coverage 84.84% 84.70% -0.15%
==========================================
Files 55 55
Lines 5584 5590 +6
==========================================
- Hits 4738 4735 -3
- Misses 846 855 +9
|
samster25
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Looks great! Can you also add NotNull to our partition transform rewriter here
https://github.com/Eventual-Inc/Daft/blob/main/src/daft-scan/src/expr_rewriter.rs#L130
Added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1720
Adds
not_nullexpression to check if values are not NullChanges: