Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix type annotation on UDF #1807

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[BUG] Fix type annotation on UDF #1807

merged 2 commits into from
Jan 22, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Jan 22, 2024

Closes #1801

@github-actions github-actions bot added the bug Something isn't working label Jan 22, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 22, 2024
@jaychia jaychia enabled auto-merge (squash) January 22, 2024 20:31
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fc7f053) 84.95% compared to head (dbd9d3b) 84.94%.

❗ Current head dbd9d3b differs from pull request most recent head cfa2c7a. Consider uploading reports for the commit cfa2c7a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1807      +/-   ##
==========================================
- Coverage   84.95%   84.94%   -0.02%     
==========================================
  Files          55       55              
  Lines        5656     5658       +2     
==========================================
+ Hits         4805     4806       +1     
- Misses        851      852       +1     
Files Coverage Δ
daft/udf.py 93.47% <75.00%> (-0.97%) ⬇️

@jaychia jaychia merged commit 596a3d9 into main Jan 22, 2024
40 checks passed
@jaychia jaychia deleted the jay/udf-signature branch January 22, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix return type annotation of UDF return type
1 participant