[BUG] [Parquet] Fix double-await on JoinHandle
s concurrency bug in Parquet reader.
#1841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a double-await concurrency bug on
JoinHandle
s in the Parquet reader. The bug appears to arise when an a byte range fetch fails: we currently short-circuit that fetch and return an error to the stream mapper without changing the range cache state. This means that future fetches that overlap with that byte range will try to.await
on the sameJoinHandle
, which is not allowed.This PR fixes this by storing a
Result<Bytes, Error>
inRangeCacheState::Ready()
, so we can stash errors from past fetches.TODOs