Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Fix monotonically_increasing_id physical op #1853

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Feb 8, 2024

#1827 was failing in CI, here's the fix

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1fae7ad) 85.47% compared to head (70afb65) 85.53%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1853      +/-   ##
==========================================
+ Coverage   85.47%   85.53%   +0.06%     
==========================================
  Files          55       55              
  Lines        6119     6147      +28     
==========================================
+ Hits         5230     5258      +28     
  Misses        889      889              
Files Coverage Δ
daft/dataframe/dataframe.py 87.52% <100.00%> (+0.06%) ⬆️
daft/execution/execution_step.py 93.66% <100.00%> (+0.16%) ⬆️
daft/execution/physical_plan.py 95.05% <100.00%> (+0.05%) ⬆️
daft/logical/builder.py 90.16% <100.00%> (+0.24%) ⬆️
daft/table/micropartition.py 90.32% <100.00%> (+0.09%) ⬆️
daft/table/table.py 85.16% <100.00%> (+0.09%) ⬆️

Copy link
Member

@samster25 samster25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colin-ho colin-ho merged commit 1066ace into main Feb 8, 2024
46 checks passed
@colin-ho colin-ho deleted the colin/fix_merge branch February 8, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants