-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Remove non-MicroPartition
and non-ScanOperator
paths
#1946
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1946 +/- ##
==========================================
- Coverage 85.63% 83.93% -1.71%
==========================================
Files 55 55
Lines 6250 6111 -139
==========================================
- Hits 5352 5129 -223
- Misses 898 982 +84
|
@clarkzinzow btw: it still looks like github actions is still running the matrix over MICROPARTITIONS |
@samster25 Hmm I thought that I removed that from the actions config, let me double-check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -303,128 +290,6 @@ def num_outputs(self) -> int: | |||
return 1 | |||
|
|||
|
|||
@dataclass(frozen=True) | |||
class ReadFile(SingleOutputInstruction): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goodbye and thank you for your service 🫡
We'll need github repo admin permissions to change our "Required" CI steps before we can actually merge! |
5d52fc6
to
3ab8ff3
Compare
@jaychia Not sure if I understand how the required workflows work, but I just rebased this PR on latest main, so I think we can have someone with admin repo privileges force-merge the PR since all pre-merge checks are green, without waiting for the post-merge checks to run. I assume that our required workflows are reusing our normal pre-merge workflows as a "reusable" workflow, so once the reusable workflows are updated in main via merging this PR, main commits and PR commits should be post-merge tested using the updated workflows as expected. Am I understanding our required workflows setup correctly? I don't think I have permissions to see it, let alone modify it, unfortunately. |
Oh! I was just suggesting that when we’re ready to merge I can go into the panel and switch everything out so we get a green merge
No action items on your end, just lmk when we're ready 😁
|
@jaychia should be good to merge now! |
Edited |
This PR removes the legacy non-
MicroPartition
and non-ScanOperator
code paths, refactoring where required. As a drive-by, this PR also refactors the query optimization tests to use structural equality assertions instead of repr-based ones, and adds additional test coverage around scan pushdowns.Closes #1863
Closes #1939
Closes #1945