[PERF] Spread scan tasks over Ray cluster. #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkzinzow
commented
Feb 26, 2024
| ) | ||
| ] | ||
|
|
||
|
|
There was a problem hiding this comment.
Decided to move these to execution_step.py since it's a more sensible location for them, and to not introduce an otherwise unnecessary ray_runner.py -> rust_physical_plan_shim.py dependency.
samster25
approved these changes
Feb 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1950 +/- ##
=======================================
Coverage 83.93% 83.93%
=======================================
Files 55 55
Lines 6111 6112 +1
=======================================
+ Hits 5129 5130 +1
Misses 982 982
|
BenchmarkingSetup28 GiB Parquet data, 32 partitions, 8 i3.2xlarge Ray nodes each with 61 GiB RAM (18.3 GiB object store) ResultsBefore PR
After PR
|
|
I'm considering this change to be validated, merging now! |
samster25
pushed a commit
that referenced
this pull request
Feb 27, 2024
This PR forces a `SPREAD` scheduling strategy for scan tasks when using the Ray runner. This should result in better load balancing of read tasks across the Ray cluster, yielding: - better utilization of the aggregate network bandwidth of the cluster, - better memory stability due to a more even post-read object distribution, - better performance of downstream parallel compute operations due to a more even distribution of data over the compute bandwidth of the cluster. Closes #1940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forces a
SPREADscheduling strategy for scan tasks when using the Ray runner. This should result in better load balancing of read tasks across the Ray cluster, yielding:Closes #1940