Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] adding floor function #1960

Merged
merged 1 commit into from
Feb 29, 2024
Merged

[FEAT] adding floor function #1960

merged 1 commit into from
Feb 29, 2024

Conversation

chandbud5
Copy link
Contributor

Adding floor function. Resolves - #1910

@chandbud5 chandbud5 changed the title add floor function [FEAT] adding floor function Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.95%. Comparing base (cc7b957) to head (590d59b).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1960      +/-   ##
==========================================
+ Coverage   83.90%   83.95%   +0.05%     
==========================================
  Files          55       55              
  Lines        6112     6125      +13     
==========================================
+ Hits         5128     5142      +14     
+ Misses        984      983       -1     
Files Coverage Δ
daft/expressions/expressions.py 91.33% <100.00%> (+0.10%) ⬆️
daft/series.py 93.15% <100.00%> (+0.07%) ⬆️

... and 2 files with indirect coverage changes

@samster25 samster25 added the enhancement New feature or request label Feb 29, 2024
Copy link
Member

@samster25 samster25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks for knocking this out :)

@samster25 samster25 merged commit dff4933 into Eventual-Inc:main Feb 29, 2024
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants