Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] [Hotfix] Remove pyarrow upper bound for Windows. #2002

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

clarkzinzow
Copy link
Contributor

@clarkzinzow clarkzinzow commented Mar 12, 2024

The pyarrow < 7.0.0 upper bound is needlessly restrictive, since

  1. Ray already has that upper-bound since their pickle bug workaround doesn't work for Windows, so if a Windows user is using Ray + Daft, their pyarrow should already satisfy that upper bound.
  2. If a user isn't using Ray, then they shouldn't need that upper bound anyway, since we're not using pyarrow + pickle when only using the local runner.

@clarkzinzow clarkzinzow changed the title [CHORE] Remove pyarrow upper bound for Windows. [CHORE] [Hotfix] Remove pyarrow upper bound for Windows. Mar 12, 2024
@github-actions github-actions bot added the chore label Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.70%. Comparing base (118e141) to head (e1d1b53).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2002   +/-   ##
=======================================
  Coverage   84.70%   84.70%           
=======================================
  Files          58       58           
  Lines        6363     6363           
=======================================
  Hits         5390     5390           
  Misses        973      973           

@clarkzinzow clarkzinzow merged commit 093e8d7 into main Mar 12, 2024
33 checks passed
@clarkzinzow clarkzinzow deleted the clark/pyarrow-remove-upper-bound branch March 12, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants