[FEAT] Add str.capitalize() function #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murex971
force-pushed
the
murex/capitalize-str
branch
2 times, most recently
from
48234aa
to
4fc08bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2003 +/- ##
==========================================
- Coverage 84.70% 84.27% -0.44%
==========================================
Files 58 59 +1
Lines 6363 6409 +46
==========================================
+ Hits 5390 5401 +11
- Misses 973 1008 +35
|
jaychia
reviewed
Mar 12, 2024
src/daft-core/src/array/ops/utf8.rs
Outdated
| Some(first) => { | ||
| let firstchar = first.to_uppercase(); | ||
| let mut res = String::with_capacity(v.len()); | ||
| res.extend(firstchar); |
There was a problem hiding this comment.
Nit: it seems that firstchar may actually not be a single character in certain special cases, based on https://doc.rust-lang.org/std/primitive.char.html#method.to_uppercase
Let's rename the firstchar variable to first_char_uppercased?
src/daft-core/src/array/ops/utf8.rs
Outdated
| let firstchar = first.to_uppercase(); | ||
| let mut res = String::with_capacity(v.len()); | ||
| res.extend(firstchar); | ||
| for c in chars { |
There was a problem hiding this comment.
nit: prefer iterator chaining if possible
res.extend(chars.flat_map(|c| c.to_lowercase()))
murex971
force-pushed
the
murex/capitalize-str
branch
from
4fc08bb
to
226b3ee
Compare
|
@jaychia thanks for the review. Pushed the changes. |
|
Congrats on first PR!!! 🚀🚀🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uppercase the first letter, lowercase the rest.
Resolves #1919