Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix struct getters on logical types #2008

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Mar 13, 2024

Struct getters on logical types were failing with:

Mismatch of expected expression data type and data type from computed series, <logical> vs <physical>

This PR fixes this by fixing the implementation of .with_validity on our logical arrays, which previously were erroneously returning Series of the physical type.

@jaychia jaychia marked this pull request as ready for review March 13, 2024 03:07
@jaychia jaychia requested a review from colin-ho March 13, 2024 03:07
@github-actions github-actions bot added the bug Something isn't working label Mar 13, 2024
@jaychia jaychia enabled auto-merge (squash) March 13, 2024 03:09
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.72%. Comparing base (093e8d7) to head (e4e17ef).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2008      +/-   ##
==========================================
+ Coverage   84.70%   84.72%   +0.01%     
==========================================
  Files          58       58              
  Lines        6363     6369       +6     
==========================================
+ Hits         5390     5396       +6     
  Misses        973      973              

see 1 file with indirect coverage changes

@jaychia jaychia merged commit 9e45a7b into main Mar 13, 2024
33 checks passed
@jaychia jaychia deleted the jay/fix-with-validity-logical branch March 13, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant