Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix connector-x and psycopg dependencies for CI #2017

Merged
merged 6 commits into from
Mar 15, 2024
Merged

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Mar 15, 2024

Use psycopg-binary as benchmarking runner does not have required libraries installed. Fixed here: https://github.com/Eventual-Inc/daft-benchmarking/actions/runs/8291353023

Use connector-x 0.2.3 on linux on aarch-64. Fixed here: https://github.com/Eventual-Inc/Daft/actions/runs/8291745511

@github-actions github-actions bot added the bug Something isn't working label Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.70%. Comparing base (578944f) to head (ceca81a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2017   +/-   ##
=======================================
  Coverage   82.70%   82.70%           
=======================================
  Files          62       62           
  Lines        6615     6615           
=======================================
  Hits         5471     5471           
  Misses       1144     1144           

@colin-ho colin-ho merged commit 957a25b into main Mar 15, 2024
41 checks passed
@colin-ho colin-ho deleted the colin/fix-ci branch March 15, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant