[FEAT] Add str.replace expression #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
jaychia
approved these changes
Apr 1, 2024
src/daft-core/src/array/ops/utf8.rs
Outdated
| let pattern_arrow = pattern.as_arrow(); | ||
| let replacement_arrow = replacement.as_arrow(); | ||
|
|
||
| if self.is_empty() || pattern.is_empty() || replacement.is_empty() { |
There was a problem hiding this comment.
Should this be && instead?
If any are empty, then all should be empty -- otherwise it's a length and we should throw an error?
There was a problem hiding this comment.
I made a separate issue (#2058) to tackle this cuz we'll probably want to add test cases for this change (and for all the other kernels), which is out of scope for this PR
src/daft-core/src/array/ops/utf8.rs
Outdated
| } | ||
| } | ||
| }, | ||
| (self_len,1,1) => { |
There was a problem hiding this comment.
Pretty crazy that we have so many match cases. I wonder if there's a better way to perform this.
Perhaps something like this at least?
self_iter, pattern_iter, replacement_iter = ...;
if regex {
regex_replace(...)
} else {
replace_on_literal(...)
}
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2048 +/- ##
==========================================
+ Coverage 85.23% 85.27% +0.03%
==========================================
Files 68 68
Lines 7248 7259 +11
==========================================
+ Hits 6178 6190 +12
+ Misses 1070 1069 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1932
Closes #1962
Replaces all occurrences of a pattern in a string column with a replacement string. The pattern can be a literal or a regex pattern.