Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] fill_null expression #2089

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[FEAT] fill_null expression #2089

merged 1 commit into from
Apr 11, 2024

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Apr 5, 2024

Closes #1904

@github-actions github-actions bot added the enhancement New feature or request label Apr 5, 2024
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (2e644b9) to head (3d68dcc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2089      +/-   ##
==========================================
+ Coverage   85.24%   85.28%   +0.04%     
==========================================
  Files          68       68              
  Lines        7258     7267       +9     
==========================================
+ Hits         6187     6198      +11     
+ Misses       1071     1069       -2     
Files Coverage Δ
daft/expressions/expressions.py 91.94% <100.00%> (+0.06%) ⬆️
daft/series.py 92.95% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

@jaychia jaychia requested a review from kevinzwang April 8, 2024 18:01
@samster25
Copy link
Member

@kevinzwang You have time Wednesday to take a look?

Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar enough with our usage of semantic id to fully understand that part, but otherwise LGTM!

@colin-ho colin-ho merged commit acb8203 into main Apr 11, 2024
31 checks passed
@colin-ho colin-ho deleted the colin/fill_null branch April 11, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EXPRESSIONS] .fill_null(fill_value)
3 participants