-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Enable Ruff #2121
[FEAT] Enable Ruff #2121
Conversation
samster25
commented
Apr 15, 2024
•
edited
Loading
edited
- Enable ruff to speed up linting and increase the number of rules we're using
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2121 +/- ##
==========================================
+ Coverage 85.05% 85.09% +0.04%
==========================================
Files 68 68
Lines 7332 7326 -6
==========================================
- Hits 6236 6234 -2
+ Misses 1096 1092 -4
|
Amazing! I'm looking forward to how much this will reduce pre-commit wait times. :) |
@MeepoWin me too! There's also so many Ruff rules to avoid footguns :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to exclude vendored files, like the cloudpickle code? We'd ideally like to keep vendored files as close to their source as possible, in case we want to pull in upstream changes.
@@ -0,0 +1,33 @@ | |||
fix = true | |||
indent-width = 4 | |||
line-length = 120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this isn't the time to litigate this, but at some point I'd like to discuss dropping this to 80 or Black's default of 88, since 120 often isn't great for reviewing PRs or editing horizontal code panes on a 14-16" laptop.
A discussion for the future! 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah happy to discuss offline! Not super attached to this
Done! now ignore the cloud pickle files. |