[FEAT] Implements other trigonometry expressions #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeepoWin
commented
Apr 15, 2024
samster25
reviewed
Apr 15, 2024
| if not is_arc: | ||
| table = MicroPartition.from_pydict({"a": [0.0, math.pi, math.pi / 2, math.nan]}) | ||
| else: | ||
| table = MicroPartition.from_pydict({"a": [0.0, 1, 0.5, math.nan]}) |
There was a problem hiding this comment.
we should also have tests to ensure behavior for non valid values. A panic is probably fine!
I ran a test case on duckdb for asin for pi.
There was a problem hiding this comment.
Fair enough. However, I think nan is more appropriate(this is also the behavior of this PR), because there may be only a few invalid values in a series at any one time, but panic will stop the world. You can always use something like dropNan to filter out invalid values if needed.
Closed
This was referenced Jul 3, 2024
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only trigonometric function we are missing from Ibis is
arctan2, which I will implement in other PRs.This closes #1908
This closes #1915