Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Add S3Config.from_env functionality #2137

Merged
merged 12 commits into from
Apr 16, 2024
Merged

[FEAT] Add S3Config.from_env functionality #2137

merged 12 commits into from
Apr 16, 2024

Commits on Apr 15, 2024

  1. [FEAT] Add IOConfig.from_env functionality

    Jay Chia committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    cd7e51d View commit details
    Browse the repository at this point in the history

  2. Move functionality out into daft-io instead to avoid dependencies on … 

    …AWS SDK from configs
    Jay Chia committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    74b2719 View commit details
    Browse the repository at this point in the history

  3. Patches IOConfig.from_env onto the Python class

    Jay Chia committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    73217f2 View commit details
    Browse the repository at this point in the history

  4. Reduce diff

    Jay Chia committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    f871334 View commit details
    Browse the repository at this point in the history

  5. Add docstring

    Jay Chia committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    d9c557e View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Implement IOConfig.from_env using dynamic Python imports

    Jay Chia committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c843df1 View commit details
    Browse the repository at this point in the history

  2. Implement S3Config.from_env instead

    Jay Chia committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    24ed2aa View commit details
    Browse the repository at this point in the history

  3. Detect endpoint from envvars

    Jay Chia committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    26dade0 View commit details
    Browse the repository at this point in the history

  4. Do not perform endpoint discovery

    Jay Chia committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    0c1c9b4 View commit details
    Browse the repository at this point in the history

  5. Propagate error for loading credentials

    Jay Chia committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    66f1f83 View commit details
    Browse the repository at this point in the history

  6. intern python strings

    Jay Chia committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    57be6f0 View commit details
    Browse the repository at this point in the history

  7. Update docstrings

    Jay Chia committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9f1c1ac View commit details
    Browse the repository at this point in the history