Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] improve recursive listing error msg #2145

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

avriiil
Copy link
Contributor

@avriiil avriiil commented Apr 17, 2024

This adds a more descriptive error message to the glob_scan to direct users towards recursive listing capabilities

Closes #2109

@avriiil avriiil changed the title improve recursive listing error msg [CHORE] improve recursive listing error msg Apr 17, 2024
@github-actions github-actions bot added the chore label Apr 17, 2024
@jaychia
Copy link
Contributor

jaychia commented Apr 17, 2024

Nice! The error message should also be {}/**, since in our globbing syntax the ** must be a standalone "fragment". I think we should be able to do this by stripping the right-most / in glob_path and then adding / in the error string!

@avriiil
Copy link
Contributor Author

avriiil commented Apr 22, 2024

@jaychia - my rust is not great, but this seems to do the trick. lmk what you think

@jaychia jaychia merged commit 6982286 into Eventual-Inc:main Apr 22, 2024
27 checks passed
@jaychia
Copy link
Contributor

jaychia commented Apr 22, 2024

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading partitioned Parquet file from top-level directory fails
2 participants