Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] collect all tests before running pytest so check for import errors #2150

Merged
merged 3 commits into from
Apr 18, 2024
Merged

[CHORE] collect all tests before running pytest so check for import errors #2150

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95e894a
collect all tests before running pytest so check for import erros
samster25 Apr 18, 2024
3b35e6e
ignore int tests
samster25 Apr 18, 2024
090c357
qq mode on pytest collect
samster25 Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ jobs:
# export CARGO_INCREMENTAL=1
# cargo llvm-cov clean --workspace
maturin develop
pytest --ignore tests/integration --collect-only -qq # run this to ensure no weird imports that result in `Collector` errors
mkdir -p report-output && pytest --cov=daft --ignore tests/integration --durations=50
coverage combine -a --data-file='.coverage' || true
coverage xml -o ./report-output/coverage-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.daft-runner }}-${{ matrix.pyarrow-version }}.xml
Expand Down
Loading