Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Add logarithmic expressions #2168

Merged
merged 4 commits into from
Apr 26, 2024
Merged

[FEAT] Add logarithmic expressions #2168

merged 4 commits into from
Apr 26, 2024

Conversation

murex971
Copy link
Contributor

Resolves #1911
Resolves #1913
Resolves #1914

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 22, 2024
@murex971 murex971 requested a review from samster25 April 25, 2024 05:03
@samster25 samster25 requested a review from colin-ho April 25, 2024 23:52
@samster25
Copy link
Member

could you take a look @colin-ho!

colin-ho
colin-ho reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@colin-ho colin-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean @murex971! Just left some comments about enabling logarithmic functionality for int types

src/daft-core/src/series/ops/log.rs Outdated Show resolved Hide resolved
src/daft-core/src/series/ops/log.rs Outdated Show resolved Hide resolved
src/daft-core/src/series/ops/log.rs Outdated Show resolved Hide resolved
tests/table/test_eval.py Outdated Show resolved Hide resolved
@murex971 murex971 requested a review from colin-ho April 26, 2024 10:27
@colin-ho
Copy link
Contributor

LGTM! Thanks @murex971

@colin-ho colin-ho merged commit 69bdaad into Eventual-Inc:main Apr 26, 2024
27 checks passed
@jaychia jaychia mentioned this pull request May 17, 2024
Closed
@colin-ho colin-ho mentioned this pull request May 28, 2024
Closed
@jhasm jhasm mentioned this pull request May 29, 2024
Merged
colin-ho pushed a commit that referenced this pull request May 30, 2024
@jhasm
[EXPRESSIONS] Add log with custom base (#2324)
e99f993 
### Resolves 
1. #2315

### Summary
This change adds a new expression `log` to compute log with custom base.

### Testing
* Unit tests added to cover the new changes.

### Related PRs
* #2168 used as a reference to
keep all log related expressions uniform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-ho colin-ho colin-ho approved these changes

@samster25 samster25 Awaiting requested review from samster25

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EXPRESSIONS] .log2 [EXPRESSIONS] .log10 [EXPRESSIONS] .ln
3 participants
@murex971 @samster25 @colin-ho