Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Rust side exceptions for Transient Errors #2197

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Apr 29, 2024

#2136

  • Enables Python checkable exceptions when performing IO in Daft
  • Currently raises the following:
  • DaftTypeError
  • ConnectTimeoutError
  • ReadTimeoutError
  • ByteStreamError
  • SocketError

@github-actions github-actions bot added the enhancement New feature or request label Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.32%. Comparing base (a0fd6ec) to head (b92c515).
Report is 5 commits behind head on main.

❗ Current head b92c515 differs from pull request most recent head 54cdaeb. Consider uploading reports for the commit 54cdaeb to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2197      +/-   ##
==========================================
+ Coverage   85.10%   85.32%   +0.22%     
==========================================
  Files          68       69       +1     
  Lines        7391     7455      +64     
==========================================
+ Hits         6290     6361      +71     
+ Misses       1101     1094       -7     
Files Coverage Δ
daft/exceptions.py 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

@samster25 samster25 changed the title [FEAT] Rust side exceptions [FEAT] Rust side exceptions for Transient Errors Apr 30, 2024
@samster25 samster25 requested a review from jaychia April 30, 2024 06:19
@samster25 samster25 merged commit c439cbc into main Apr 30, 2024
31 checks passed
@samster25 samster25 deleted the sammy/rust-side-exceptions branch April 30, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants