Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add user guide for read_sql #2226

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented May 3, 2024

No description provided.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.59%. Comparing base (24d0831) to head (3be68d6).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2226   +/-   ##
=======================================
  Coverage   85.59%   85.59%           
=======================================
  Files          71       71           
  Lines        7586     7594    +8     
=======================================
+ Hits         6493     6500    +7     
- Misses       1093     1094    +1     
Files Coverage Δ
daft/io/_sql.py 52.38% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@samster25 samster25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! 🚀

@samster25 samster25 merged commit 69ccf21 into main May 7, 2024
29 checks passed
@samster25 samster25 deleted the colin/read_sql_user_guide branch May 7, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants