Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Allow multiple group_bys for pivot #2242

Merged
merged 3 commits into from
May 7, 2024

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented May 6, 2024

Currently df.pivot only accepts a single group_by column, this PR adds functionality to use multiple columns.

@github-actions github-actions bot added the chore label May 6, 2024
@colin-ho colin-ho requested a review from jaychia May 6, 2024 23:13
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.64%. Comparing base (c57aaad) to head (aeee2dc).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #2242       +/-   ##
=========================================
+ Coverage      0   85.64%   +85.64%     
=========================================
  Files         0       71       +71     
  Lines         0     7642     +7642     
=========================================
+ Hits          0     6545     +6545     
- Misses        0     1097     +1097     
Files Coverage Δ
daft/dataframe/dataframe.py 90.20% <100.00%> (ø)
daft/execution/execution_step.py 93.77% <100.00%> (ø)
daft/execution/rust_physical_plan_shim.py 96.25% <ø> (ø)
daft/logical/builder.py 91.04% <100.00%> (ø)
daft/table/micropartition.py 90.70% <100.00%> (ø)
daft/table/table.py 56.86% <0.00%> (ø)

... and 65 files with indirect coverage changes

Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean :)

@colin-ho colin-ho merged commit e47b48a into main May 7, 2024
29 checks passed
@colin-ho colin-ho deleted the colin/pivot-multiple-group-by branch May 7, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants