-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Allow nulls in partition column #2344
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2344 +/- ##
=======================================
Coverage ? 79.00%
=======================================
Files ? 475
Lines ? 55264
Branches ? 0
=======================================
Hits ? 43661
Misses ? 11603
Partials ? 0
|
src/daft-stats/src/partition_spec.rs
Outdated
return false; | ||
} | ||
} else { | ||
let both_null = self_column |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for partition spec we want the behavior that null == null
? if so, we should document that here
if !value_eq { | ||
return false; | ||
} | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a simpler way to represent this could be:
else if self_is_null xor other_is_null {
return false;
}
17cc5f8
to
c794012
Compare
Closes #2292
Currently Daft panics if there are nulls in a partition column, the detailed error message can be found in the linked issue.
A simple reproduction:
This PR modifies the partition spec equality logic and partition pruning semantics to allow reading nulls in partition columns.