[FEAT] Implements trigonometry expressions: arctanh arccosh arcsinh #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
requesting review @colin-ho |
colin-ho
reviewed
Jul 5, 2024
There was a problem hiding this comment.
Thanks for this @fedemagnani ! Just 2 small nits and this PR should be good to go
tests/table/test_eval.py
Outdated
| @@ -367,6 +367,51 @@ def test_table_numeric_atan2_literals() -> None: | |||
| ) | |||
|
|
|||
|
|
|||
| def test_table_numeric_arctanh() -> None: | |||
| table = MicroPartition.from_pydict({"a": [0.0, 0.5, 0.9, -0.9, -0.5, -0.0, math.nan]}) | |||
There was a problem hiding this comment.
Can you also test that for values |x| >= 1, the arctanh expression returns Nan?
tests/table/test_eval.py
Outdated
|
|
||
|
|
||
| def test_table_numeric_arccosh() -> None: | ||
| table = MicroPartition.from_pydict({"a": [1.0, 2.0, 1.5, math.nan]}) |
There was a problem hiding this comment.
And here, if you could also test that values x < 1 evaluate to NaN
added 2 commits
July 5, 2024 15:26
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2476 +/- ##
=======================================
Coverage ? 63.43%
=======================================
Files ? 947
Lines ? 106377
Branches ? 0
=======================================
Hits ? 67479
Misses ? 38898
Partials ? 0
|
colin-ho
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2470
Closes #2471
Closes #2472