[BUG] Fix count("*") behavior
#2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2733 will not alter performanceComparing Summary
|
jaychia
approved these changes
Aug 27, 2024
daft/dataframe/dataframe.py
Outdated
|
|
||
| >>> import daft | ||
| >>> df = daft.from_pydict({"foo": [1, None, None], "bar": [None, 2, 2]}) | ||
| >>> from daft import col | ||
| >>> df = daft.from_pydict({"foo": [1, None, None], "bar": [None, 2, 2], "baz": [3, 4, 5]}) | ||
| >>> df.count().show() |
There was a problem hiding this comment.
Let's add a comment here that this is equivalent to df.count("*")?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2733 +/- ##
=======================================
Coverage ? 63.37%
=======================================
Files ? 981
Lines ? 113258
Branches ? 0
=======================================
Hits ? 71777
Misses ? 41481
Partials ? 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding wildcard expansion, this started expanding out into all columns, which is not the expected behavior from SQL.