Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] expose more type info #2762

Merged

Conversation

chuanlei-coding
Copy link
Contributor

add helper functions to determine whether a datatype is list/string/boolean.

@chuanlei-coding chuanlei-coding changed the title expore more type info [FEAT] expore more type info Aug 29, 2024
@github-actions github-actions bot added the enhancement New feature or request label Aug 29, 2024
Copy link

codspeed-hq bot commented Aug 29, 2024

CodSpeed Performance Report

Merging #2762 will degrade performances by 18.6%

Comparing chuanlei-coding:feat-expore-more-type-info (21732a8) with main (3c365e6)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main chuanlei-coding:feat-expore-more-type-info Change
test_count[1 Small File] 19.7 ms 24.2 ms -18.6%
test_explain[100 Small Files] 55.5 ms 37 ms +49.99%
test_show[100 Small Files] 479.5 ms 375.7 ms +27.61%

@chuanlei-coding chuanlei-coding changed the title [FEAT] expore more type info [FEAT] expose more type info Aug 29, 2024
@samster25
Copy link
Member

Thanks @chuanlei-coding!

@samster25 samster25 merged commit 36401ab into Eventual-Inc:main Aug 29, 2024
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants