-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Implement thiserror::Error for DaftError and arrow2::Error #2785
Conversation
CodSpeed Performance ReportMerging #2785 will degrade performances by 33.98%Comparing Summary
Benchmarks breakdown
|
- this solves a couple of tests, since they relied on the output being strings produced from display printouts instead of debug printouts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2785 +/- ##
=======================================
Coverage ? 63.24%
=======================================
Files ? 1002
Lines ? 113729
Branches ? 0
=======================================
Hits ? 71929
Misses ? 41800
Partials ? 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Overview
thiserror::Error
forcommon::error::DaftError
andarrow2::error::Error
impl From<X> for DaftError
and manyimpl From<X> for arrow2::Error