Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Enable all targets for cargo check #2792

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Sep 5, 2024

Fixes issue where a test could be invalid rust but still pass precommit

@github-actions github-actions bot added the chore label Sep 5, 2024
@samster25 samster25 changed the title [CHORE] Enable All targets [CHORE] Enable all targets for cargo check Sep 5, 2024
@samster25 samster25 enabled auto-merge (squash) September 5, 2024 19:16
Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #2792 will improve performances by ×5.7

Comparing sammy/enable-cargo-check-all-targets (5c4337c) with main (7fe3dbc)

Summary

⚡ 2 improvements
✅ 14 untouched benchmarks

Benchmarks breakdown

Benchmark main sammy/enable-cargo-check-all-targets Change
test_count[1 Small File] 23.9 ms 10.5 ms ×2.3
test_show[100 Small Files] 296.6 ms 52.1 ms ×5.7

@samster25 samster25 merged commit c6afd78 into main Sep 5, 2024
39 checks passed
@samster25 samster25 deleted the sammy/enable-cargo-check-all-targets branch September 5, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant