Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add docs to hash and hash to docs #2821

Merged
merged 3 commits into from
Sep 10, 2024
Merged

[DOCS] Add docs to hash and hash to docs #2821

merged 3 commits into from
Sep 10, 2024

Conversation

kevinzwang
Copy link
Member

@kevinzwang kevinzwang commented Sep 9, 2024

Also fixes link in Expression.approx_count_distinct

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 9, 2024
Copy link

codspeed-hq bot commented Sep 9, 2024

CodSpeed Performance Report

Merging #2821 will improve performances by ×4.7

Comparing kevin/hash-docs (60da539) with main (7bee225)

Summary

⚡ 2 improvements
✅ 14 untouched benchmarks

Benchmarks breakdown

Benchmark main kevin/hash-docs Change
test_count[1 Small File] 24 ms 10.3 ms ×2.3
test_show[100 Small Files] 227.2 ms 48.9 ms ×4.7

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.32%. Comparing base (7bee225) to head (212352c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2821   +/-   ##
=======================================
  Coverage   63.32%   63.32%           
=======================================
  Files        1008     1008           
  Lines      114165   114165           
=======================================
+ Hits        72292    72293    +1     
+ Misses      41873    41872    -1     
Files with missing lines Coverage Δ
daft/expressions/expressions.py 93.50% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link

github-actions bot commented Sep 10, 2024

@kevinzwang kevinzwang merged commit ee0b973 into main Sep 10, 2024
40 checks passed
@kevinzwang kevinzwang deleted the kevin/hash-docs branch September 10, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant