-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT]: sql float operations #2834
[FEAT]: sql float operations #2834
Conversation
CodSpeed Performance ReportMerging #2834 will degrade performances by 30.18%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not have a scalar_udf
macro for this? If we do, maybe we could utilize that to avoid all of this boilerplate...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly for the other functions inside of daft-functions/src/float
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to come up with a macro for this, but I think the consensus was that it wasn't intuitive & could make things harder to debug later on. So I just stuck with copy and paste.
No description provided.