Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: sql float operations #2834

Merged
merged 12 commits into from
Sep 16, 2024

Conversation

universalmind303
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Sep 11, 2024
Copy link

codspeed-hq bot commented Sep 11, 2024

CodSpeed Performance Report

Merging #2834 will degrade performances by 30.18%

Comparing universalmind303:sql-floats (ceec3bd) with main (805fbce)

Summary

❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:sql-floats Change
test_count[1 Small File] 16.3 ms 23.3 ms -30.18%

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not have a scalar_udf macro for this? If we do, maybe we could utilize that to avoid all of this boilerplate...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly for the other functions inside of daft-functions/src/float as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to come up with a macro for this, but I think the consensus was that it wasn't intuitive & could make things harder to debug later on. So I just stuck with copy and paste.

@universalmind303 universalmind303 merged commit 3980f12 into Eventual-Inc:main Sep 16, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants