[CHORE] Defer Register of Super Type #2836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2836 will degrade performances by 56.61%Comparing Summary
Benchmarks breakdown
|
desmondcheongzx
added a commit
that referenced
this pull request
Sep 19, 2024
Introduce lazy imports for heavy modules that are not needed as top-level imports. For example, `ray` does not need to be a top level import (it should only be imported when using the ray runner or when specific ray data extension types needed. Another example would be `UnityCatalogTable`, which is a relatively heavy import despite only being needed when using delta lake. Modules to import lazily were determined by the proportion of import time as shown by `importtime-output-wrapper -c 'import daft' --format waterfall --depth 25`. The list of newly lazily imported modules are: - `daft.unity_catalog` - `fsspec` - `numpy` - `pandas` - `PIL.Image` - `pyarrow` - `pyarrow.csv` - `pyarrow.dataset` - `pyarrow.fs` - `pyarrow.json` - `pyarrow.parquet` - `ray` - `ray.data.extensions` - `xml.etree.ElementTree` Uses #2836 in order to defer the import of `pyarrow`. Additionally, we move all type-checking-only module imports into type checking blocks. With these changes, import times go from roughly 0.6-0.7s to ~0.045s (~13-15x faster). --------- Co-authored-by: Sammy Sidhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.