-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Sql groupby fix #2843
[BUG]: Sql groupby fix #2843
Conversation
CodSpeed Performance ReportMerging #2843 will degrade performances by 69.77%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One thing I'm wondering is what the behavior should be when grouping by something that is not just a column, such as SELECT * FROM table GROUP BY a + b
. Right now it errors but the error messages come from the logical plan builder and do not really make sense in the context of the SQL query itself. Perhaps we just disallow it explicitly.
addresses #2835