Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Dataframe.filter method #2853

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

universalmind303
Copy link
Collaborator

closes #2846

Note, this does not rename 'where' to 'filter' but instead just adds an alias. We can revisit at a later date if we want to deprecate the where method.

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 17, 2024
daft/dataframe/dataframe.py Show resolved Hide resolved
@universalmind303 universalmind303 enabled auto-merge (squash) September 17, 2024 15:25
Copy link

codspeed-hq bot commented Sep 17, 2024

CodSpeed Performance Report

Merging #2853 will degrade performances by 56.43%

Comparing universalmind303:df-filter (ad4c3a3) with main (07e92f6)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:df-filter Change
test_count[1 Small File] 10.4 ms 23.8 ms -56.43%
test_explain[100 Small Files] 292.5 ms 33.3 ms ×8.8
test_show[100 Small Files] 363.5 ms 50.9 ms ×7.1

@universalmind303 universalmind303 merged commit 6766955 into Eventual-Inc:main Sep 17, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename DataFrame.where to DataFrame.filter?
2 participants