Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[FEAT]: shuffle_join_default_partitions param" #2873

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Sep 20, 2024

Reverts #2844

@github-actions github-actions bot added the enhancement New feature or request label Sep 20, 2024
Copy link

codspeed-hq bot commented Sep 20, 2024

CodSpeed Performance Report

Merging #2873 will not alter performance

Comparing revert-2844-default_join_partitions (e0c85ea) with main (a3c98a5)

Summary

✅ 17 untouched benchmarks

@jaychia jaychia enabled auto-merge (squash) September 20, 2024 23:36
@jaychia jaychia merged commit b0f31e3 into main Sep 20, 2024
38 checks passed
@jaychia jaychia deleted the revert-2844-default_join_partitions branch September 20, 2024 23:53
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.26%. Comparing base (a3c98a5) to head (e0c85ea).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2873      +/-   ##
==========================================
+ Coverage   62.80%   66.26%   +3.45%     
==========================================
  Files        1002     1003       +1     
  Lines      120310   113552    -6758     
==========================================
- Hits        75562    75242     -320     
+ Misses      44748    38310    -6438     
Flag Coverage Δ
66.26% <100.00%> (+3.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
daft/context.py 73.71% <ø> (ø)
src/common/daft-config/src/lib.rs 87.50% <ø> (-0.22%) ⬇️
src/common/daft-config/src/python.rs 70.62% <ø> (-1.12%) ⬇️
src/daft-plan/src/physical_planner/translate.rs 91.77% <100.00%> (-0.56%) ⬇️

... and 78 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants