-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Refactor Binary Ops #2876
Merged
Merged
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c62887e
wip
samster25 60e230e
working comparisions
samster25 aa048a3
factor out python macros to function
samster25 69dc9d9
move code out of series mod
samster25 eed7da4
move utils to series
samster25 524c118
factor out logical
samster25 fe229d1
faster inc builds
samster25 8319b3a
merge in main
samster25 9cce0ea
clean up
samster25 b0694df
working bitwise
samster25 89b9ad6
fix name for add
samster25 2d98d54
enable boolean ops
samster25 ca5e1c7
merge in main
samster25 35a62b0
lint fixes
samster25 d8beb13
add temporal types
samster25 1585c6c
del old code
samster25 ca0d185
remove commented out code
samster25 c8e6774
Merge remote-tracking branch 'origin' into sammy/refactor-bin-ops
samster25 a753a7b
enable build macros to be level 3
samster25 31f90cd
rename macros
samster25 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really need opt-level=1 in dev? That seems like it'll greatly slow down the build times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left that artifact in by mistake, I meant to push up the optimization level change for build macros