Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] UTF8 to binary coercion flag #2893

Merged
merged 13 commits into from
Sep 24, 2024
Merged

[FEAT] UTF8 to binary coercion flag #2893

merged 13 commits into from
Sep 24, 2024

Commits on Sep 23, 2024

  1. Add flag to always coerce utf8 to binary

    @raunakab
    raunakab committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c4bc2fd View commit details
    Browse the repository at this point in the history

  2. Add logic to modify datatype based on string-to-binary-coercion flag

    @raunakab
    raunakab committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    01ca502 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Add test for invalid UTF-8 coercion to binary when flag is set

    @raunakab
    raunakab committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    012e2d1 View commit details
    Browse the repository at this point in the history

  2. Edit python APIs for coercing utf8s to binary

    @raunakab
    raunakab committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    96cd554 View commit details
    Browse the repository at this point in the history

  3. Change coerce_string_to_binary to string_encoding 

    - more extensible!
    @raunakab
    raunakab committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1100a0a View commit details
    Browse the repository at this point in the history

  4. Update conversion logic

    @raunakab
    raunakab committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ca3d4b7 View commit details
    Browse the repository at this point in the history

  5. Change "utf8" to "utf-8" instead

    @raunakab
    raunakab committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    43965fe View commit details
    Browse the repository at this point in the history

  6. Add python test for testing new string-encoding option

    @raunakab
    raunakab committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    75a2a5f View commit details
    Browse the repository at this point in the history

  7. Instead of str | None = "utf-8" for string-encoding option, use `st… 

    …r = "utf-8"`

- users can specify `"raw"` instead
    @raunakab
    raunakab committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a73000c View commit details
    Browse the repository at this point in the history

  8. Update python bindings

    @raunakab
    raunakab committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e846a2c View commit details
    Browse the repository at this point in the history

  9. Edit comment

    @raunakab
    raunakab committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d04e672 View commit details
    Browse the repository at this point in the history

  10. Change from None to "raw"

    @raunakab
    raunakab committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    37dfa93 View commit details
    Browse the repository at this point in the history

  11. Address pytest changes that were requested

    @raunakab
    raunakab committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    58c0730 View commit details
    Browse the repository at this point in the history