Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix display for decimal types #2909

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[BUG] Fix display for decimal types #2909

merged 1 commit into from
Sep 24, 2024

Conversation

raunakab
Copy link
Contributor

Overview

  • fixed decimal printout
  • was being printed out like {}.{}
  • changed to Decimal(precision={}, scale={}) instead

@github-actions github-actions bot added the bug Something isn't working label Sep 24, 2024
@raunakab raunakab marked this pull request as ready for review September 24, 2024 19:30
@raunakab raunakab linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link

codspeed-hq bot commented Sep 24, 2024

CodSpeed Performance Report

Merging #2909 will not alter performance

Comparing bug/decimal-display (2907d77) with main (c66e384)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.29%. Comparing base (e3dd671) to head (2907d77).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2909      +/-   ##
==========================================
+ Coverage   74.36%   77.29%   +2.92%     
==========================================
  Files         596      596              
  Lines       72079    70930    -1149     
==========================================
+ Hits        53605    54822    +1217     
+ Misses      18474    16108    -2366     
Flag Coverage Δ
77.29% <ø> (+2.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/daft-schema/src/dtype.rs 81.03% <ø> (+7.99%) ⬆️

... and 65 files with indirect coverage changes

@raunakab raunakab merged commit 02b30be into main Sep 24, 2024
40 checks passed
@raunakab raunakab deleted the bug/decimal-display branch September 24, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weird schema when reading parquet with decimal dtypes
2 participants