Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] fix link in doc #2944

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

amitschang
Copy link
Contributor

I noticed a small error in documentation, looks like markdown style link used mistakenly.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 26, 2024
Copy link

codspeed-hq bot commented Sep 26, 2024

CodSpeed Performance Report

Merging #2944 will not alter performance

Comparing amitschang:small-doc-fix (b8239b3) with main (396c004)

Summary

✅ 17 untouched benchmarks

Copy link
Contributor

@ccmao1130 ccmao1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@@ -30,7 +30,7 @@ Daft does not use an index

Dask aims for as much feature-parity with pandas as possible, including maintaining the presence of an Index in the DataFrame. But keeping an Index is difficult when moving to a distributed computing environment. Dask doesn’t support row-based positional indexing (with .iloc) because it does not track the length of its partitions. It also does not support pandas MultiIndex. The argument for keeping the Index is that it makes some operations against the sorted index column very fast. In reality, resetting the Index forces a data shuffle and is an expensive operation.

Daft drops the need for an Index to make queries more readable and consistent. How you write a query should not change because of the state of an index or a reset_index call. In our opinion, eliminating the index makes things simpler, more explicit, more readable and therefore less error-prone. Daft achieves this by using the [Expressions API](../user_guide/basic_concepts/expressions).
Daft drops the need for an Index to make queries more readable and consistent. How you write a query should not change because of the state of an index or a reset_index call. In our opinion, eliminating the index makes things simpler, more explicit, more readable and therefore less error-prone. Daft achieves this by using the :doc:`Expressions API <../user_guide/basic_concepts/expressions>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think its supposed to be redirecting to https://www.getdaft.io/projects/docs/en/stable/api_docs/expressions.html since it's referencing Expressions API so it should be ../api_docs/expressions?

@amitschang
Copy link
Contributor Author

@ccmao1130, updated!

@ccmao1130 ccmao1130 merged commit 272163f into Eventual-Inc:main Oct 7, 2024
36 checks passed
@ccmao1130
Copy link
Contributor

Thank you @amitschang !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants