[BUG]: add count_matches and fix a bunch of str functions #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2946 will not alter performanceComparing Summary
|
universalmind303
requested review from
raunakab and
jaychia
and removed request for
raunakab and
jaychia
kevinzwang
approved these changes
Sep 30, 2024
| @@ -17,13 +20,14 @@ impl SQLModule for SQLModuleUtf8 { | |||
| parent.add_fn("ends_with", EndsWith); | |||
| parent.add_fn("starts_with", StartsWith); | |||
| parent.add_fn("contains", Contains); | |||
| parent.add_fn("split", Split(true)); | |||
| parent.add_fn("split", Split(false)); | |||
There was a problem hiding this comment.
Unrelated to this change, but it would be nice to have some docs on the Utf8Expr enum on what the boolean parameter for Split means, as well as the other enum values
sagiahrac
pushed a commit
to sagiahrac/Daft
that referenced
this pull request
Oct 7, 2024
…nc#2946) a bunch of improvements to the str functions in SQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a bunch of improvements to the str functions in SQL