Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] add/fix many clippy lints #2978

Merged
merged 10 commits into from
Oct 7, 2024
Merged

[CHORE] add/fix many clippy lints #2978

merged 10 commits into from
Oct 7, 2024

Conversation

andrewgazelka
Copy link
Member

mostly auto-fix; a few manual fixes

@andrewgazelka andrewgazelka changed the title add many clippy lints [CHORE] add/fix many clippy lints Sep 30, 2024
@github-actions github-actions bot added the chore label Sep 30, 2024
Copy link

codspeed-hq bot commented Oct 1, 2024

CodSpeed Performance Report

Merging #2978 will not alter performance

Comparing andrew/clippy (a1b9c8c) with main (98dbadb)

Summary

✅ 17 untouched benchmarks

@samster25
Copy link
Member

as discussed offline, lets remove src/{arrow2, parquet2} from the linter since we pulled them in tree from a fork.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 67.05882% with 392 lines in your changes missing coverage. Please review.

Project coverage is 78.16%. Comparing base (98dbadb) to head (a1b9c8c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-table/src/python.rs 5.00% 38 Missing ⚠️
src/daft-core/src/array/ops/get.rs 26.66% 22 Missing ⚠️
src/daft-scan/src/lib.rs 16.66% 20 Missing ⚠️
src/daft-io/src/azure_blob.rs 0.00% 15 Missing ⚠️
src/common/file-formats/src/file_format_config.rs 17.64% 14 Missing ⚠️
src/daft-io/src/huggingface.rs 6.66% 14 Missing ⚠️
src/common/io-config/src/python.rs 58.62% 12 Missing ⚠️
src/daft-local-execution/src/sources/source.rs 0.00% 12 Missing ⚠️
src/common/io-config/src/s3.rs 9.09% 10 Missing ⚠️
src/daft-io/src/google_cloud.rs 0.00% 9 Missing ⚠️
... and 87 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2978      +/-   ##
==========================================
- Coverage   78.37%   78.16%   -0.22%     
==========================================
  Files         603      603              
  Lines       71466    71850     +384     
==========================================
+ Hits        56009    56159     +150     
- Misses      15457    15691     +234     
Files with missing lines Coverage Δ
src/common/daft-config/src/lib.rs 87.50% <ø> (ø)
src/common/daft-config/src/python.rs 77.34% <ø> (ø)
src/common/display/src/ascii.rs 0.00% <ø> (ø)
src/common/display/src/tree.rs 37.50% <100.00%> (+8.92%) ⬆️
src/common/display/src/utils.rs 0.00% <ø> (ø)
src/common/io-config/src/config.rs 37.50% <ø> (ø)
src/common/io-config/src/lib.rs 58.06% <100.00%> (ø)
src/common/py-serde/src/python.rs 77.77% <ø> (ø)
src/common/system-info/src/lib.rs 96.15% <100.00%> (ø)
src/common/treenode/src/lib.rs 94.11% <100.00%> (ø)
... and 250 more

... and 5 files with indirect coverage changes

@andrewgazelka
Copy link
Member Author

andrewgazelka commented Oct 1, 2024

@samster25 has noted some of at least one of these lints might be controversial so def interested in the team opinion for some of them.

Copy link
Collaborator

@universalmind303 universalmind303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of these 2 rules, but if everyone else approves, I won't get in the way.

src/daft-image/src/image_buffer.rs Outdated Show resolved Hide resolved
src/daft-image/src/series.rs Outdated Show resolved Hide resolved
@andrewgazelka andrewgazelka merged commit 0c39007 into main Oct 7, 2024
39 of 40 checks passed
@andrewgazelka andrewgazelka deleted the andrew/clippy branch October 7, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants