-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Add resources to Ray stateful UDF actor #2987
Conversation
CodSpeed Performance ReportMerging #2987 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2987 +/- ##
==========================================
+ Coverage 78.31% 78.35% +0.03%
==========================================
Files 602 602
Lines 71012 71049 +37
==========================================
+ Hits 55615 55669 +54
+ Misses 15397 15380 -17
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a test? I think you can access the Ray resource requests from inside a Ray actor. Check out some of our resource request tests
daft/runners/pyrunner.py
Outdated
self, | ||
name: str, | ||
actor_resource_request: ResourceRequest, | ||
_: ResourceRequest, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this, why do we need it?
If this is the task-based one we can also do _task_resource_request
Fix for #2878
Not sure how feasible it is to unit test this since it would likely require access to a GPU. However I tested this on a GPU machine and can confirm that this PR fixes GPU availability in stateful actors when using the ray runner.