Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add resources to Ray stateful UDF actor #2987

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

kevinzwang
Copy link
Member

@kevinzwang kevinzwang commented Oct 2, 2024

Fix for #2878

Not sure how feasible it is to unit test this since it would likely require access to a GPU. However I tested this on a GPU machine and can confirm that this PR fixes GPU availability in stateful actors when using the ray runner.

@github-actions github-actions bot added the bug Something isn't working label Oct 2, 2024
Copy link

codspeed-hq bot commented Oct 2, 2024

CodSpeed Performance Report

Merging #2987 will not alter performance

Comparing kevin/ray-actor-resources (7754d52) with main (62d0581)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (fe4553f) to head (7754d52).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2987      +/-   ##
==========================================
+ Coverage   78.31%   78.35%   +0.03%     
==========================================
  Files         602      602              
  Lines       71012    71049      +37     
==========================================
+ Hits        55615    55669      +54     
+ Misses      15397    15380      -17     
Files with missing lines Coverage Δ
daft/execution/physical_plan.py 94.28% <ø> (+0.15%) ⬆️
daft/runners/pyrunner.py 85.25% <100.00%> (ø)
daft/runners/ray_runner.py 80.69% <100.00%> (+0.06%) ⬆️
daft/runners/runner.py 71.87% <ø> (ø)

... and 7 files with indirect coverage changes

@kevinzwang kevinzwang marked this pull request as ready for review October 3, 2024 04:19
@kevinzwang kevinzwang changed the title [BUG] Add proper resources to Ray stateful UDF actor [BUG] Add resources to Ray stateful UDF actor Oct 3, 2024
Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test? I think you can access the Ray resource requests from inside a Ray actor. Check out some of our resource request tests

self,
name: str,
actor_resource_request: ResourceRequest,
_: ResourceRequest,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this, why do we need it?

If this is the task-based one we can also do _task_resource_request

@kevinzwang kevinzwang enabled auto-merge (squash) October 4, 2024 18:51
@kevinzwang kevinzwang merged commit a62d276 into main Oct 4, 2024
40 checks passed
@kevinzwang kevinzwang deleted the kevin/ray-actor-resources branch October 4, 2024 19:29
sagiahrac pushed a commit to sagiahrac/Daft that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants