Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Streaming physical writes for native executor #2992
[FEAT] Streaming physical writes for native executor #2992
Changes from all commits
4d5af1a
823e889
3854cd2
56c8416
b662ad9
4db34f0
4f12640
9ed8e84
16f3f7d
11d9244
685416b
85ab44c
0ce9dcc
03dcfcb
bc9c7fa
92c4d03
072ae6e
b67499e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check warning on line 3 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L1-L3
Check warning on line 7 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L5-L7
Check warning on line 14 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L12-L14
Check warning on line 18 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L18
Check warning on line 22 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L21-L22
Check warning on line 35 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L32-L35
Check warning on line 40 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L37-L40
Check warning on line 44 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L44
Check warning on line 46 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L46
Check warning on line 50 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L48-L50
Check warning on line 52 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L52
Check warning on line 55 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L54-L55
Check warning on line 61 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L61
Check warning on line 64 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L63-L64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we name this something like
start_next_file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mirroring the above comment, the python file writers should not write after close
Check warning on line 70 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L70
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also have a
finalize
method rather than overloadingclose
to start a next file and closing the last fileThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actually intending for these Python writers to be non rotating. i.e. no writing after closing. They should be given a unique file_idx for the file_name generation upon construction, and unique set of partition_values.
I will add assertions and some comments to document this behaviour
Check warning on line 74 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L73-L74
Check warning on line 82 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L82
Check warning on line 91 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L90-L91
Check warning on line 94 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L93-L94
Check warning on line 106 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L102-L106
Check warning on line 110 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L108-L110
Check warning on line 117 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L112-L117
Check warning on line 121 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L120-L121
Check warning on line 128 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L128
Check warning on line 136 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L135-L136
Check warning on line 139 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L138-L139
Check warning on line 148 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L144-L148
Check warning on line 152 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L150-L152
Check warning on line 159 in daft/io/writer.py
Codecov / codecov/patch
daft/io/writer.py#L154-L159
Check warning on line 39 in src/daft-core/src/utils/identity_hash_set.rs
Codecov / codecov/patch
src/daft-core/src/utils/identity_hash_set.rs#L37-L39